Adding FCC-hh analysis example, code and event weight processing #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge in changes to core analyzers code
…->RP in latest edm4hep versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the FCC-hh analysis code in a dedicated analyzer, as well as a first small working FCC-hh example (removing all the no longer working old ones), as well as a first attempt at processing the event weights (which are != 1 in FCC-hh samples) correctly. All for edm4hep v1.
Things to note:
do_weightedis set from the respective analysis python script. Behaviour for analyses not setting this should be unchanged. The validity of correct scaling with weights and sum of weights is still to be confirmed (once above problem is solved).Resolved WIP items:
The code to retrieve heavy flavour tagging from Delphes is technically working, but does not produce expected physics results in tests. This is to be fixed still.-> PR131 in k4SimDelphes fixes this, the b-tagging efficiency has been confirmed to be as expected for the FCC-hh Delphes card using a small sample of bbyy events.