Adding FCC-hh analysis example, code and event weight processing #411
Conversation
Merge in changes to core analyzers code
…->RP in latest edm4hep versions
python/run_final_analysis.py
Outdated
| if do_weighted: | ||
| LOGGER.info('Using generator weights') | ||
| sow_process={} | ||
| sow_ttree={} |
There was a problem hiding this comment.
Why not use process_events?
There was a problem hiding this comment.
If you meant to fully replace it (not just init it as the same), I think we also want to keep the raw number of events to check the MC statistics e.g., don't we?
|
Is there any reason, why not to introduce default weight of the event to be equal to one regardless whether there are input files which contains the information or not? |
|
Can you also add an explanation for the |
Do you mean instead of having the |
|
Yes, to have 1s as default. Having one more column is I think reasonable trade-off. There are some analysis on the FCCee side coming which will need event weights as well. |
Ok, sure. But could we just merge it like this with the option for now, and then I make the changes to not use the option anymore but default weight = 1 in a separate PR? |
Done. |
This PR adds the FCC-hh analysis code in a dedicated analyzer, as well as a first small working FCC-hh example (removing all the no longer working old ones), as well as code for processing the event weights (which are != 1 in FCC-hh samples) correctly. All for edm4hep v1, but not yet using
DataSource.Things to note:
do_weightedis set from the respective analysis python script. Behaviour for analyses not setting this should be unchanged. Validity of the normalisation with sum of weights and cross-section has been checked with a small sample of bbyy events.The code to retrieve heavy flavour tagging from Delphes is technically working, but does not produce expected physics results in tests. This is to be fixed still.-> PR131 in k4SimDelphes fixes this, the b-tagging efficiency has been confirmed to be as expected for the FCC-hh Delphes card using a small sample of bbyy events.