Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve dependencies definition #16

Merged
merged 3 commits into from
Mar 17, 2020
Merged

Improve dependencies definition #16

merged 3 commits into from
Mar 17, 2020

Conversation

Sinclert
Copy link
Contributor

Before starting with the pyhf schema integration, I think it is better if dependencies are defined in a single place (setup.py) instead of being define both in requirements.txt and setup.py.

The reason to move them to setup.py is because this tool lays into the "package" category, not in the "application" one.

In addition, I have:

  • Bumped up version to 0.2.2.
  • Added license header to .travis.yml.
  • Removed duplication of installation within travis.yml.
  • Formatted setup.py.

Copy link
Contributor

@alisonrclarke alisonrclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. @GraemeWatt your call on the version number - I guess if we don't normally bump it until we do the release then perhaps we should follow that process?

@GraemeWatt GraemeWatt merged commit cff5bf4 into HEPData:master Mar 17, 2020
@GraemeWatt
Copy link
Member

I've left the version number at 0.2.2. I don't think it matters too much, but it's probably better to increase it after making a tagged release. (In the past, I didn't fully understand the GitHub integration with PyPI and I was worried that bumping the version number might trigger a release automatically.)

GraemeWatt added a commit that referenced this pull request Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants