Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remote schemas validation #17

Merged
merged 19 commits into from
Apr 22, 2020
Merged

Remote schemas validation #17

merged 19 commits into from
Apr 22, 2020

Conversation

Sinclert
Copy link
Contributor

@Sinclert Sinclert commented Mar 17, 2020 •
edited
Loading

This PR aims to partially tackle HEPData/hepdata#164, as the hepdata validator needs to support "remotely defined" schemas in order to allow submissions containing data files from other organizations / companies.

Decisions taken:

  • Remote schemas will be organized by company/project/version.
  • They will be stored separately from the native HEP schemas.

Clarifications:

  • I have mocked tests in order for them not to depend on an external https://... resource.
  • I have updated the docs for supporting the HTTPSchemasDownloader new entity.

@coveralls
Copy link

coveralls commented Mar 17, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling c1b502c on Sinclert:pyhf-integration into 5db8fb7 on HEPData:master.

@Sinclert
Copy link
Contributor Author

I have updated this PR:

  • Substituting the previously named company attribute by org.
  • Defining a new private method called parse_remote_url, that parses the initialization schemas URL and checks for its correctness.

@Sinclert
Copy link
Contributor Author

Sinclert commented Apr 3, 2020

I have updated this PR:

  • Adding a new get_schema_type method to build a valid type value to be passed to the DataFileValidator.

@kratsg
Copy link

kratsg commented Apr 6, 2020

./cc @lukasheinrich @matthewfeickert

@Sinclert
Copy link
Contributor Author

Sinclert commented Apr 7, 2020

I have updated this PR by adding a real world pyhf test (the file is around 19.000 lines long).

I would say it is now ready for review. If the test file is considered too long, we can prune it as desired 😄

@Sinclert Sinclert changed the title Schemas downloader impl. Remote schemas validation Apr 8, 2020
Sinclert and others added 5 commits April 8, 2020 16:02
@Sinclert
Define SchemaResolver tests
068c038
@Sinclert
Update documentation
af9403c
@Sinclert
Apply Graeme README suggestion
3736295
@GraemeWatt
Update README, add "data_schema" to submission schema, bump version
bc44d25 
* Refinements to usage documentation in README.rst file.
* Add "data_schema" and "table_doi" keys to submission_schema.json.
* Need to bump schema version to 1.0.1 after making these changes.
* Add an example submission.yaml file that uses the "data_schema" key.

Signed-off-by: Graeme Watt <[email protected]>
@GraemeWatt
Use yaml.safe_load in README and minor refinements to docstrings
c1b502c 
Signed-off-by: Graeme Watt <[email protected]>
@GraemeWatt GraemeWatt merged commit be6b82a into HEPData:master Apr 22, 2020
@GraemeWatt GraemeWatt mentioned this pull request Apr 22, 2020
Closed
@Sinclert Sinclert deleted the pyhf-integration branch April 23, 2020 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Sinclert @coveralls @kratsg @GraemeWatt