Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix scaling when dealing with masked arrays #1769

Merged
merged 1 commit into from
Dec 19, 2024
Merged

fix scaling when dealing with masked arrays #1769

merged 1 commit into from
Dec 19, 2024

Conversation

saransh13
Copy link
Member

The cartesian view is a numpy.ma.masked_array. This was not correctly handled by the polar plot intensity scaling functions.

@saransh13 saransh13 requested a review from psavery December 19, 2024 00:23
@pep8speaks
Copy link

pep8speaks commented Dec 19, 2024

Hello @saransh13! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2024-12-19 15:14:38 UTC

Copy link
Collaborator

@psavery psavery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made it a little cleaner

@saransh13 saransh13 merged commit ca87363 into master Dec 19, 2024
9 checks passed
@saransh13 saransh13 deleted the scaling-fix branch December 19, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants