Avoid nested functions in QueuedConnections #1770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The one in the indexing runner in particular was freezing the application starting in Qt 6.8.1. I'm not entirely sure why, but making the function a method on the class rather than making it a nested function appears to fix the issue. We'll just try to avoid using nested functions in Qt QueuedConnections. Signed-off-by: Patrick Avery <[email protected]>
bnmajor
approved these changes
Jan 8, 2025
psavery
force-pushed
the
remove-lambda-queued-connections
branch
from
e507cd4 to
9af9994
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The one in the indexing runner in particular was freezing the application starting in Qt 6.8.1. I'm not entirely sure why, but making the function a method on the class rather than making it a nested function appears to fix the issue.
We'll just try to avoid using nested functions in Qt QueuedConnections.