feat(web): allow to shutdown faster when there is no more requests on h1 #1193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelwurtz
force-pushed
the
feat/shutdown-when-no-requests
branch
from
52ce564 to
27dfc69
Compare
joelwurtz
commented
Jan 30, 2025
| @@ -34,7 +34,7 @@ async fn h1_get() -> Result<(), Error> { | |||
| assert_eq!("GET Response", body); | |||
| } | |||
|
|
|||
| handle.try_handle()?.stop(false); | |||
There was a problem hiding this comment.
before this change this would wait for the keep alive timeout, now it shut down instantly (because there is no pending request)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #1190
Still a draft but this is an example on how we could shutdown faster and cleanly even when there is still pending connections, this is a proof of concept on h1 dispatcher, h2 and h3 can do something similar also
I used a
tokio::sync::watchchanneltokio_util::CancellationTokento check for shutdown change but maybe there is a better solution (there is a lot of things to adapt, like naming, correct deps, etc ... but this is mainly an example for the moment)