Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Prod] Merge goal request, fix bug with other entities, display correct options for creator/approver #2133

Merged
merged 10 commits into from
May 3, 2024

Conversation

thewatermethod
Copy link
Collaborator

@thewatermethod thewatermethod commented May 3, 2024

Description of change

  • Button text for creators who were also approvers was incorrect
  • It was possible to remove objectives from an other entity report after adding them and the report would be submittable
  • Region 3 requested a goal merge

How to test

Bug with other entity reports:

  • Create an other-entity report
  • Add required data, including objectives
  • Delete objectives
  • Note the form state is updated to "In Progress" in the side navigation and you can no longer submit a report

Bug with creator-approvers

Test viewing the report in three states as three types of users Creator, Collaborator, Approver:

  1. Draft
  2. Submitted
  3. Needs Action

Goal merge request

Only viewable once code has been merged to production

Issue(s)

Checklists

Every PR

  • Meets issue criteria
  • JIRA ticket status updated
  • Code is meaningfully tested
  • Meets accessibility standards (WCAG 2.1 Levels A, AA)
  • API Documentation updated
  • Boundary diagram updated
  • Logical Data Model updated
  • Architectural Decision Records written for major infrastructure decisions
  • UI review complete

Before merge to main

  • OHS demo complete
  • Ready to create production PR

Production Deploy

  • Staging smoke test completed

After merge/deploy

  • Update JIRA ticket status

@thewatermethod thewatermethod marked this pull request as ready for review May 3, 2024 14:16
@Jones-QuarteyDana Jones-QuarteyDana merged commit cb0450b into production May 3, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants