-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Prod] Show user regions in the site navigation #2202
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n-AR-header' into lr/ttahub-1521/display-regions-in-AR-header
…y-regions-in-AR-header
…y-regions-in-AR-header
…y-regions-in-AR-header
…y-regions-in-AR-header
Bumps [@grpc/grpc-js](https://github.com/grpc/grpc-node) from 1.9.12 to 1.10.9. - [Release notes](https://github.com/grpc/grpc-node/releases) - [Commits](https://github.com/grpc/grpc-node/compare/@grpc/[email protected]...@grpc/[email protected]) --- updated-dependencies: - dependency-name: "@grpc/grpc-js" dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
…gions-in-AR-header
…gions-in-AR-header
…gions-in-AR-header
…R-header [TTAHUB-1521] - Display regions in AR Landing header/SiteNav
[TTAHUB-2307] Fix missing variable for production
Jones-QuarteyDana
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
User's regions are displayed below their name in the SiteNav. If user has access to multiple regions, the AR landing page title will be "Activity reports - your regions" and if they only have access to one region, the title will be "Activity reports - your region". In site nav, there are 3 versions under the user's name: Region #, Regions #, #, #, and All Regions (see ticket with mockups). Also corrected the alignment of the "New Activity Report" button, and spacing between that button and filter button at smaller device widths.
This PR also includes a fix for a missing environment variable in the production environment. Since the Smartsheet integration is limited to non-production environments, production was missing this variable, causing an issue with deployment. This fix adds the variable but sets it to an empty value.
How to test
Issue(s)
Checklists
Every PR
Production Deploy
After merge/deploy