Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Prod] Show user regions in the site navigation #2202

Merged
merged 36 commits into from
Jun 11, 2024
Merged

Conversation

thewatermethod
Copy link
Collaborator

@thewatermethod thewatermethod commented Jun 11, 2024

Description of change

User's regions are displayed below their name in the SiteNav. If user has access to multiple regions, the AR landing page title will be "Activity reports - your regions" and if they only have access to one region, the title will be "Activity reports - your region". In site nav, there are 3 versions under the user's name: Region #, Regions #, #, #, and All Regions (see ticket with mockups). Also corrected the alignment of the "New Activity Report" button, and spacing between that button and filter button at smaller device widths.

This PR also includes a fix for a missing environment variable in the production environment. Since the Smartsheet integration is limited to non-production environments, production was missing this variable, causing an issue with deployment. This fix adds the variable but sets it to an empty value.

How to test

  • Change user permissions to set user's home ID to region 14, with read permissions to all regions. Should see "All Regions" in SiteNav and "- your regions" in page title.
  • Change user permissions to set user's home ID to region 1, with read permissions to region 1 and 5. Should see "Regions 1,5" in SiteNav and "- your regions" in page title.
  • Change user permissions to set user's home ID to region 5, with read permissions to region 5. Should see "Region 5" in SiteNav and "- your region" in page title.
  • Reduce window size to where "New Activity Report" button moves below page title. There should be 24px between title and "New Activity Report" button and 16px between Report button and filter button.

Issue(s)

Checklists

Every PR

  • Meets issue criteria
  • JIRA ticket status updated
  • Code is meaningfully tested
  • Meets accessibility standards (WCAG 2.1 Levels A, AA)
  • [n/a] API Documentation updated
  • [n/a] Boundary diagram updated
  • [n/a] Logical Data Model updated
  • [n/a] Architectural Decision Records written for major infrastructure decisions
  • UI review complete

Production Deploy

  • Staging smoke test completed

After merge/deploy

  • Update JIRA ticket status

Spanglemonkey and others added 30 commits April 7, 2023 14:37
…n-AR-header' into lr/ttahub-1521/display-regions-in-AR-header
Bumps [@grpc/grpc-js](https://github.com/grpc/grpc-node) from 1.9.12 to 1.10.9.
- [Release notes](https://github.com/grpc/grpc-node/releases)
- [Commits](https://github.com/grpc/grpc-node/compare/@grpc/[email protected]...@grpc/[email protected])

---
updated-dependencies:
- dependency-name: "@grpc/grpc-js"
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
@thewatermethod thewatermethod changed the title [Prod] Show user regions in the side nav [Prod] Show user regions in the site navigation Jun 11, 2024
[TTAHUB-2307] Fix missing variable for production
@thewatermethod thewatermethod marked this pull request as ready for review June 11, 2024 20:41
@Jones-QuarteyDana Jones-QuarteyDana merged commit 1da401a into production Jun 11, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants