Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PROD] 06/20/24 TTAHUB-2667: Fix save pdf white space, TTAHUB-2519: Show Fei root cause per recipient #2219

Merged
merged 22 commits into from
Jun 20, 2024

Conversation

AdamAdHocTeam
Copy link
Collaborator

@AdamAdHocTeam AdamAdHocTeam commented Jun 20, 2024

Description of change

TTAHUB-2667: Fix for saving reports as PDF in windows.
TTAHUB-2519: We now show FEI root causes per recipient.
TTAHUB-2132: Add " - Active" and " - Inactive" to grant number filter on RTR.

How to test

TTAHUB-2667: Saving PDF's in windows shouldn't have any white space after 'Activity dates'.
TTAHUB-2519: Reviewing an FYI report should show root causes per recipient.
TTAHUB-2132: Ensure the list looks something like this:

Screenshot 2024-06-20 at 12 33 49 PM

Issue(s)

Checklists

Every PR

  • Meets issue criteria
  • JIRA ticket status updated
  • Code is meaningfully tested
  • Meets accessibility standards (WCAG 2.1 Levels A, AA)
  • API Documentation updated
  • Boundary diagram updated
  • Logical Data Model updated
  • Architectural Decision Records written for major infrastructure decisions
  • UI review complete

Before merge to main

  • OHS demo complete
  • Ready to create production PR

Production Deploy

  • Staging smoke test completed

After merge/deploy

  • Update JIRA ticket status

AdamAdHocTeam and others added 20 commits June 13, 2024 16:37
Bumps [urllib3](https://github.com/urllib3/urllib3) from 2.0.7 to 2.2.2.
- [Release notes](https://github.com/urllib3/urllib3/releases)
- [Changelog](https://github.com/urllib3/urllib3/blob/main/CHANGES.rst)
- [Commits](urllib3/urllib3@2.0.7...2.2.2)

---
updated-dependencies:
- dependency-name: urllib3
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [scikit-learn](https://github.com/scikit-learn/scikit-learn) from 1.3.0 to 1.5.0.
- [Release notes](https://github.com/scikit-learn/scikit-learn/releases)
- [Commits](scikit-learn/scikit-learn@1.3.0...1.5.0)

---
updated-dependencies:
- dependency-name: scikit-learn
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
[TTAHUB-2519] Add FEI root causes to report review
[TTAHUIB-2667] Fix unwanted space after activity date
[TTAHUB-2132] Add grant status to filter select
@AdamAdHocTeam AdamAdHocTeam marked this pull request as ready for review June 20, 2024 18:51
…rllib3-2.2.2

Bump urllib3 from 2.0.7 to 2.2.2 in /similarity_api/src
…cikit-learn-1.5.0

Bump scikit-learn from 1.3.0 to 1.5.0 in /similarity_api/src
@AdamAdHocTeam AdamAdHocTeam marked this pull request as ready for review June 20, 2024 20:48
Copy link
Collaborator

@kryswisnaskas kryswisnaskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging this so that it will get deployed to production before the scheduled db service upgrade.

@AdamAdHocTeam AdamAdHocTeam merged commit 340bf59 into production Jun 20, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants