Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Prod] Show validation/error message when attempting to enter a generic iPD URL #2221

Merged
merged 16 commits into from
Jun 21, 2024
Merged

[Prod] Show validation/error message when attempting to enter a generic iPD URL #2221

merged 16 commits into from
Jun 21, 2024

Conversation

thewatermethod
Copy link
Collaborator

@thewatermethod thewatermethod commented Jun 21, 2024 •
edited
Loading

Description of change

Disallow the following URLs from being entered as resources

How to test

  • Enter in the invalid URLS in the objective form (session and activity report)
  • Confirm that they cannot be saved

Issue(s)

Checklists

Every PR

  • Meets issue criteria
  • JIRA ticket status updated
  • Code is meaningfully tested
  • Meets accessibility standards (WCAG 2.1 Levels A, AA)
  • API Documentation updated
  • Boundary diagram updated
  • Logical Data Model updated
  • Architectural Decision Records written for major infrastructure decisions
  • UI review complete

Before merge to main

  • OHS demo complete
  • Ready to create production PR

Production Deploy

  • Staging smoke test completed

After merge/deploy

  • Update JIRA ticket status

dependabot bot and others added 16 commits June 18, 2024 08:48
@dependabot
Bump ws from 8.5.0 to 8.17.1
579da0a 
Bumps [ws](https://github.com/websockets/ws) from 8.5.0 to 8.17.1.
- [Release notes](https://github.com/websockets/ws/releases)
- [Commits](websockets/ws@8.5.0...8.17.1)

---
updated-dependencies:
- dependency-name: ws
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@thewatermethod
updates to common package
4602ace
@thewatermethod
v2.1.4
60fa0c6
@thewatermethod
Update isValidResourceUrl in common to bridge the gap between impleme…
b1cdcfe 
…tations
@thewatermethod
v2.1.5
83484d3
@thewatermethod
Update with common solution
812cf46
@thewatermethod
Add an additional test
19b9262
@thewatermethod
Show correct error on Session Objective
9c3ee6d
@thewatermethod
Flip validation order
9b99343
@thewatermethod
Merge remote-tracking branch 'origin/main' into mb/TTAHUB-3007/no-dis…
3ddd16d 
…allowed-urls
@thewatermethod
Improve error display generally, and deploy to dev
bea8193
@thewatermethod
Fix misnamed branch in config
d4ac670
@GarrettEHill
Merge branch 'main' into dependabot/npm_and_yarn/ws-8.17.1
6d76455
@GarrettEHill
Update yarn-audit-known-issues
5d0bb22
@GarrettEHill
Merge pull request #2215 from HHS/dependabot/npm_and_yarn/ws-8.17.1
7a29160 
Bump ws from 8.5.0 to 8.17.1
@thewatermethod
Merge pull request #2216 from HHS/mb/TTAHUB-3007/no-disallowed-urls
7bb49d7 
[TTAHUB-3006] Show validation/error message when attempting to enter a generic iPD URL
@thewatermethod thewatermethod marked this pull request as ready for review June 21, 2024 14:38
@Jones-QuarteyDana Jones-QuarteyDana merged commit 513b85d into production Jun 21, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jones-QuarteyDana Jones-QuarteyDana Jones-QuarteyDana approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thewatermethod @Jones-QuarteyDana @GarrettEHill