Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ✨ adds filter CANList Pills (Tags) #2917

Merged
merged 14 commits into from
Oct 11, 2024
Merged

feat: ✨ adds filter CANList Pills (Tags) #2917

merged 14 commits into from
Oct 11, 2024

Conversation

fpigeonjr
Copy link
Contributor

@fpigeonjr fpigeonjr commented Oct 10, 2024 •
edited
Loading

What changed

  • adds pills for CANsList filters

Issue

#347 #2909

How to test

  1. goto CANs list
  2. apply filters
  3. see pill per filter
  4. remove pill
  5. filters keep in sync
  6. table is updated

Screenshots

Screen.Recording.2024-10-10.at.5.19.01.PM.mov

Definition of Done Checklist

  • OESA: Code refactored for clarity
  • OESA: Dependency rules followed
  • Automated unit tests updated and passed
  • Automated integration tests updated and passed
  • Automated quality tests updated and passed
  • Automated load tests updated and passed
  • Automated a11y tests updated and passed
  • Automated security tests updated and passed
  • 90%+ Code coverage achieved
  • [-] Form validations updated

@fpigeonjr fpigeonjr self-assigned this Oct 10, 2024
@fpigeonjr fpigeonjr added the javascript Pull requests that update Javascript code label Oct 10, 2024
@fpigeonjr fpigeonjr changed the title wip: filter CANList Pills (Tags) feat: ✨ adds filter CANList Pills (Tags) Oct 10, 2024
@fpigeonjr fpigeonjr marked this pull request as ready for review October 10, 2024 22:16
@fpigeonjr fpigeonjr linked an issue Oct 10, 2024 that may be closed by this pull request
filter pills #2909
Closed
@fpigeonjr fpigeonjr merged commit 015e650 into main Oct 11, 2024
40 checks passed
@fpigeonjr fpigeonjr deleted the OPS-347/2909 branch October 11, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maiyerlee maiyerlee maiyerlee approved these changes

@rajohnson90 rajohnson90 rajohnson90 approved these changes

@jonnalley jonnalley Awaiting requested review from jonnalley

@johndeange johndeange Awaiting requested review from johndeange

@devops-chris devops-chris Awaiting requested review from devops-chris

@Santi-3rd Santi-3rd Awaiting requested review from Santi-3rd

Assignees

@fpigeonjr fpigeonjr

Labels
javascript Pull requests that update Javascript code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

filter pills
3 participants
@fpigeonjr @rajohnson90 @maiyerlee