Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
## Summary Fixes #2775 ### Time to review: __5 mins__ ## Changes proposed Adjusts the fields we query against and how in search ## Context for reviewers I wrote up a pretty thorough explanation of keyword vs non-keyword on #2775 - check that out. In short, the bug here is due to how the request/field being compared are tokenized. Keyword leaves a field "whole" and non-keyword tokenizes it into pieces. In the case of opportunity number splitting on each of the dashes (so `ABC-123-XYZ` becomes `["ABC", "123", "XYZ"]`. In short, to support all the ways someone might want to query for an opportunity number, it's easiest to just include both. ## Additional information Some testing locally where I set the opportunity number to `FY25-BSB-56789` and `FY25-BSB-12345` for two opportunities: <img width="1262" alt="Screenshot 2024-11-07 at 2 27 07 PM" src="https://github.com/user-attachments/assets/cec4140d-5c74-4797-a6e4-67682e6035d8"> <img width="1209" alt="Screenshot 2024-11-07 at 2 27 12 PM" src="https://github.com/user-attachments/assets/aeda447f-8ec8-430a-807f-2a3f1ac4681f"> <img width="1219" alt="Screenshot 2024-11-07 at 2 27 18 PM" src="https://github.com/user-attachments/assets/0d5235b5-cfd8-4697-a97a-43c3c098deb7"> <img width="1231" alt="Screenshot 2024-11-07 at 2 27 31 PM" src="https://github.com/user-attachments/assets/1d6746b8-baf9-4cc5-8f49-51e95eb9410e">
- Loading branch information