-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Issue #2736] refactor dateUtils to use dayJS #3892
Conversation
QUESTION: I kept the dateUtils |
…ty-contributor-simpler-grants-gov into 2736-add-dayjs
Thanks for working on this, @karinamzalez! I think you're identifying value in this function remaining, that likely just hadn't been thought of when we created the ticket, so I think we can tweak the ticket to adapt to your suggestion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks.
Summary
Fixes #2736
Time to review: 5 mins
Changes proposed
Context for reviewers
Additional information