Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Remove scipy.misc #669

Merged
merged 2 commits into from
Jan 6, 2025
Merged

[Fix] Remove scipy.misc #669

merged 2 commits into from
Jan 6, 2025

Conversation

fjosw
Copy link
Collaborator

@fjosw fjosw commented Jan 6, 2025

With the latest scipy 1.15 release scipy.misc was deprecated which triggers a warning in autograd:

DeprecationWarning: scipy.misc is deprecated and will be removed in 2.0.0
    import scipy.misc as osp_misc

We only use the misc module to provide logsumexp which has been moved to scipy.special many years ago, so removing the functionality should not change anything for users on python>=3.9.

I also changed the import in the fluidsim example (imread is deprecated in SciPy 1.0.0. Use matplotlib.pyplot.imread instead)

@fjosw fjosw requested a review from agriyakhetarpal January 6, 2025 16:02
Copy link
Collaborator

@agriyakhetarpal agriyakhetarpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @fjosw! I remember I did this myself locally but now realise that I never opened a PR for it :D

@fjosw fjosw merged commit 2213cec into master Jan 6, 2025
34 checks passed
@agriyakhetarpal agriyakhetarpal deleted the fix/remove_scipy_misc branch January 6, 2025 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants