-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Instance declarations changes #45
base: instance-declaration-changes
Are you sure you want to change the base?
Instance declarations changes #45
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think I'm ready to agree to these changes so far. The exception is the changes to the instance declarations to be specific to the IPS profiles. That change seems entirely justified and obvious, and I'm surprised that we had missed doing it until now. All it actually does, though, is add the meta.profile reference in the XML/JSON, and it probably doesn't have any material effect on validation or otherwise in the IG build, so I guess we hadn't noticed that we hadn't done it. I think we need to have some further discussion, probably in person and on Zulip, before we decide if we're ready to merge the other changes into master. And that would make sense to note with Jira ticket(s) as part of ballot feedback.
@rhausam I am happy to test (in a separate branch) and will be validating this also in the Connectathon - the goal is to make the IPS profiles easier to profile in sushi and make the changes that according to the information received, should make it possible to avoid some issues. |
Note - I didn't change the inline compositions within the bundle examples to be CompositionUVIPS, hence they still don't use named slices.