-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Event rewrite #276
Event rewrite #276
Conversation
1) Remove switch events, rename events 2) Move Event Catalog out of base spec 3) Define process and documentation template to define and mature events 4) Define computable syntax for (most) events n) Various other smaller ballot fixes
could occur for reasons other than a user intentionally logging out. Better addresses #163
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comment:
The following event maturity stages are used:
2 - Tested
2 - Considered
I am guessing one of them is incorrect. 1-Considered and 2-Tested makes more sense I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comment:
The following event maturity stages are used:
2 - Tested
2 - Considered
I am guessing one of them is incorrect. 1-Considered and 2-Tested makes more sense I think.
Hey Niklas, Fixed! Good catch. I mostly copied the CDS Hooks maturity model. Our FHIRcast maturity model is defined as part of the core specification, here: https://github.com/HL7/fhircast-docs/blob/f421bcdda27e8221e776bd9c564114998ebfbc6b/docs/specification/STU1.md#event-maturity-model Isaac |
per reviewer feedback
Few things:
|
Great catch, Will
Hey @wmaethner!
You mean the examples section on each event page, right? I see it as formatted when running locally, like this: And specifically, it's the Any idea what might be causing you to see something different?
Ah, darn, fixed!
It was intended. I thought that it was important to document the same information. Do you think we should move it's documentation entirely into the base spec? The base spec does describe how to use it. |
|
Fixes #149, #156, #101, #102, #146, #147, #148, #161, #163, #165, #166, #156, #167, #108, #213, #211, #155, #151, #150, #154, #153, #152, #107, #210, #172, #160, #215, #214, #228, #238
n) Various other smaller ballot fixes