FOR-469: Add character and word count components #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Rhyad-Zergane-HO
commented
Oct 25, 2024
Rhyad-Zergane-HO
commented
- Update git ignore to ignore ds_store
- Add hmpo-text-counter as base for new word and character counter; it implements gds character counter
- Add hmpo-word-counter to count words, based on hmpo-text-counter
- Add hmpo-character-counter to count characters, based on hmpo-text-counter
- Add unit tests for each component
- Add new global function to translate extra field keys
- Add unit test for new global function
Rhyad-Zergane-HO
force-pushed
the
FOR-469-create-new-character-counter-using-gds-component
branch
2 times, most recently
from
4694c34 to
ba60064
Compare
Rhyad-Zergane-HO
requested review from
BecioProton,
matthewdoreilly and
georgeeker
georgeeker
reviewed
Oct 25, 2024
georgeeker
reviewed
Oct 25, 2024
Rhyad-Zergane-HO
force-pushed
the
FOR-469-create-new-character-counter-using-gds-component
branch
2 times, most recently
from
196125f to
a076a4b
Compare
Rhyad-Zergane-HO
force-pushed
the
FOR-469-create-new-character-counter-using-gds-component
branch
from
a076a4b to
2886838
Compare
msjhall138
approved these changes
Oct 25, 2024
Rhyad-Zergane-HO
force-pushed
the
FOR-469-create-new-character-counter-using-gds-component
branch
3 times, most recently
from
42c8498 to
282e41c
Compare
matthewdoreilly
approved these changes
Oct 28, 2024
Rhyad-Zergane-HO
force-pushed
the
FOR-469-create-new-character-counter-using-gds-component
branch
2 times, most recently
from
a9a30ad to
b4e387a
Compare
SamChatfield
requested changes
Oct 28, 2024
Rhyad-Zergane-HO
force-pushed
the
FOR-469-create-new-character-counter-using-gds-component
branch
3 times, most recently
from
5141c16 to
285bb0e
Compare
Rhyad-Zergane-HO
force-pushed
the
FOR-469-create-new-character-counter-using-gds-component
branch
from
285bb0e to
3f0e748
Compare
Rhyad-Zergane-HO
force-pushed
the
FOR-469-create-new-character-counter-using-gds-component
branch
from
3f0e748 to
c45c333
Compare
georgeeker
approved these changes
Oct 28, 2024
BecioProton
approved these changes
Oct 28, 2024
BecioProton
deleted the
FOR-469-create-new-character-counter-using-gds-component
branch
SamChatfield
pushed a commit
that referenced
this pull request
Oct 28, 2024
…r-using-gds-component FOR-469: Add character and word count components
SamChatfield
pushed a commit
that referenced
this pull request
Oct 28, 2024
…r-using-gds-component FOR-469: Add character and word count components
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.