DD-272 Updating dependencies

Drop Node 14, 16 and 18 and allowing only 20.x || 22.x  and updating the following dependencies:
debug ^4.3.4 -> ^4.3.7
glob ^10.4.5 -> ^11.0.0
eslint ^8.57.0 -> ^9.11.1
Adding eslint-define-config and replacing .eslintrc with eslint.config.js
Adding Husky ^9.1.6 and mpo-node-standards ^2.0.0 then adding  ./husky/pre-push
mocha ^10.7.0 -> ^10.7.3
nyc ^17.0.0 -> ^17.1.0
sinon ^18.0.0 -> ^19.0.2
sinon-test ^3.1.6
globals ^15.9.0

.github/workflows/ci.yaml

@@ -13,12 +13,12 @@ jobs:
 
     strategy:
       matrix:
-        node-version: [14.x, 16.x, 18.x, 20.x]
+        node-version: [20.x, 22.x]
 
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
       - name: Use Node.js ${{ matrix.node-version }}
-        uses: actions/setup-node@v2
+        uses: actions/setup-node@v3
         with:
           node-version: ${{ matrix.node-version }}
       - name: Install dependencies

.gitignore

@@ -24,6 +24,7 @@ build/Release
 # Commenting this out is preferred by some people, see
 # https://www.npmjs.org/doc/misc/npm-faq.html#should-i-check-my-node_modules-folder-into-git-
 node_modules
+.idea/
 
 # Users Environment Variables
 .lock-wscript

.husky/pre-push

@@ -0,0 +1 @@
+npm test

eslint.config.js

@@ -0,0 +1,60 @@
+const js = require('@eslint/js');
+const globals = require('globals');
+
+
+const styleRules = {
+    quotes: ['error', 'single', { avoidEscape: true }],
+    'no-trailing-spaces': 'error',
+    indent: 'error',
+    'linebreak-style': ['error', 'unix'],
+    semi: ['error', 'always'],
+    'brace-style': ['error', '1tbs', { allowSingleLine: true }],
+    'keyword-spacing': 'error',
+    'space-before-blocks': 'error',
+    'space-before-function-paren': [
+        'error',
+        { anonymous: 'always', named: 'never' },
+    ],
+    'no-mixed-spaces-and-tabs': 'error',
+    'comma-spacing': ['error', { before: false, after: true }],
+    'key-spacing': ['error', { beforeColon: false, afterColon: true }],
+};
+
+
+module.exports = [
+    js.configs.recommended,
+    {
+        languageOptions: {
+            ecmaVersion: 2022,
+            globals: {
+                ...globals.node,
+            }
+        },
+        ignores: ['/coverage/**'],
+        rules: {
+            'no-unused-vars': [
+                'error',
+                { argsIgnorePattern: '^(err|req|res|next)$' },
+            ],
+            'one-var': ['error', { initialized: 'never' }],
+            'no-var': 'error',
+            ...styleRules,
+        },
+    },
+    // Unit tests
+    {
+        files: ['test/**'],
+        languageOptions: {
+            globals: {
+                ...globals.mocha,
+                should: 'readonly',
+                expect: 'readonly',
+                sinon: 'readonly',
+                APP_ROOT: 'readonly',
+                proxyquire: 'readonly',
+                request: 'readonly',
+                response: 'readonly',
+            },
+        },
+    },
+];

lib/formatters/json.js

@@ -2,7 +2,7 @@ module.exports = function (options = {}) {
     return function JSONFormatter(meta) {
         try {
             return JSON.stringify(meta, null, options.indent || 2 );
-        } catch (e) {
+        } catch {
             return;
         }
     };

lib/interpolate.js

@@ -31,7 +31,7 @@ interpolate.stringify = function (obj, {maxLength, maxObjects = 10, circular = '
     };
     try {
         return JSON.stringify(obj, replacer, indent);
-    } catch (e) {
+    } catch {
         return;
     }
 };

lib/module-name.js

@@ -12,7 +12,7 @@ moduleName.getStack = function () {
         Error.prepareStackTrace = function (err, stack) { return stack; };
         const err = new Error();
         stack = err.stack;
-    } catch (e) { /* eslint "no-empty":0 */ }
+    } catch { /* eslint "no-empty":0 */ }
 
     Error.prepareStackTrace = prepareStackTrace;
     return stack;
@@ -58,7 +58,7 @@ moduleName.getName = function (level) {
 
         const packageData = require(packageFile);
         return packageData.name;
-    } catch (e) {
+    } catch {
         return UNKNOWN;
     }
 };

lib/transports/file.js

@@ -59,7 +59,7 @@ class FileTransport extends StreamTransport {
         try {
             logfileDate = fs.statSync(this._filename).mtime;
             debug('Existing log file date', logfileDate);
-        } catch (e) {
+        } catch {
             debug('No existing log file');
         }
         return logfileDate;