Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Bike Sharing for EzUA 1.2.0 #103

Merged
merged 2 commits into from
Dec 19, 2023
Merged

Update Bike Sharing for EzUA 1.2.0 #103

merged 2 commits into from
Dec 19, 2023

Conversation

dpoulopoulos
Copy link
Collaborator

@dpoulopoulos dpoulopoulos commented Dec 14, 2023 •
edited by AlexanderOllman
Loading

Update the Bike Sharing demo to work with EzUA 1.2.0.

Closes #102

Checklist:

  • I have checked that my enhancements are not duplicates of existing content changes or additions.
  • I have tested the changes in a working environment to ensure they function as intended.
  • I have followed the style guide outlined in the contribution guidelines.

Reviewer's Tasks (for maintainers reviewing this PR):

  • Verify that the tutorial functions correctly in a live environment.
  • Verify that the updated content aligns with the style guide in the contribution guidelines.
  • Check for consistency, grammar, and clarity throughout the updated content.
  • Check that the related GitHub issue is up-to-date.

Dimitris Poulopoulos added 2 commits December 14, 2023 12:40
bike-sharing: Use Python venv module
3c77363 
Use the Python `venv` module to create a Python virtual
environment instead of conda, as conda is too slow.

Signed-off-by: Dimitris Poulopoulos <[email protected]>
bike-sharing: Update Bike-Sharing to work with EzUA 1.2.0
b19d80d 
Closes #102

Signed-off-by: Dimitris Poulopoulos <[email protected]>
@dpoulopoulos dpoulopoulos added the bug Something isn't working label Dec 14, 2023
@dpoulopoulos dpoulopoulos self-assigned this Dec 14, 2023
@dpoulopoulos dpoulopoulos marked this pull request as ready for review December 14, 2023 12:47
AlexanderOllman
AlexanderOllman approved these changes Dec 19, 2023
View reviewed changes
Copy link
Collaborator

@AlexanderOllman AlexanderOllman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All functional requirements that I also observed have been addressed.

@dpoulopoulos dpoulopoulos merged commit 99e2a18 into develop Dec 19, 2023
@prasadadireddi prasadadireddi deleted the feature-bike-sharing-1.2.0 branch November 14, 2024 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexanderOllman AlexanderOllman AlexanderOllman approved these changes

Assignees

@dpoulopoulos dpoulopoulos

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dpoulopoulos @AlexanderOllman