Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: dt-6033 raasepori instance, logo height config fix #4865

Merged
merged 1 commit into from
Sep 21, 2023
Merged

feat: dt-6033 raasepori instance, logo height config fix #4865

merged 1 commit into from
Sep 21, 2023

Conversation

sharhio
Copy link
Contributor

@sharhio sharhio commented Sep 20, 2023

Proposed Changes

  • New waltti Raasepori instance
  • Raasepori removed from waltti-alt
  • Logo height added to scss config for instance specific adjustments (default 100%)

Pull Request Check List

  • A reasonable set of unit tests is included
  • Console does not show new warnings/errors
  • Changes are documented or they are self explanatory
  • This pull request does not have any merge conflicts
  • All existing tests pass in CI build
  • Code coverage does not decrease (unless measured incorrectly)

Review

  • Read and verify the code changes
  • Test the functionality by running the UI locally with all popular browsers available in your platform
  • Check that the implementation matches the design, when such one is defined in a Jira issue
  • Merge the pull request

@vesameskanen vesameskanen merged commit 6ea65fb into v3 Sep 21, 2023
5 checks passed
@vesameskanen vesameskanen deleted the DT-6033 branch September 21, 2023 12:49
optionsome added a commit that referenced this pull request Oct 10, 2023
@optionsome
Revert "Merge pull request #4865 from HSLdevcom/DT-6033"
408e9d1 
This reverts commit 6ea65fb, reversing
changes made to 24a88f7.
vesameskanen added a commit that referenced this pull request Oct 12, 2023
@vesameskanen
Revert "Revert "Merge pull request #4865 from HSLdevcom/DT-6033""
f20f8bc 
This reverts commit 408e9d1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vesameskanen vesameskanen vesameskanen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sharhio @vesameskanen