Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict crawling to pages that were not redirected #101

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

pmeenan
Copy link
Member

@pmeenan pmeenan commented Nov 30, 2023

This changes the crawl link extraction to only extract links if the page that loaded was on the same origin as the page the was tested (no crossorigin redirects).

Better might be to update the agent and add logic to fail the test entirely if the page does a crossorigin redirect.

Copy link

Custom metrics for https://almanac.httparchive.org/en/2022/

WPT test run results: http://webpagetest.httparchive.org/results.php?test=231130_NY_1

Copy link
Member

@tunetheweb tunetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pmeenan pmeenan merged commit db6484d into main Dec 1, 2023
2 checks passed
@pmeenan pmeenan deleted the crawl-sameorigin branch December 1, 2023 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants