Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Shopify metadata to ecommerce.js #94

Merged
merged 2 commits into from
Sep 26, 2023
Merged

Add Shopify metadata to ecommerce.js #94

merged 2 commits into from
Sep 26, 2023

Conversation

rviscomi
Copy link
Member

Test: https://webpagetest.httparchive.org/result/230926_A1_2/1/details/ (https://americanpetfood.com)

Results:
{
    "AndroidAppLinks": 1,
    "iOSUniveralLinks": 0,
    "shopify": {
        "shop": "fastpetfood.myshopify.com",
        "locale": "en",
        "currency": {
            "active": "USD",
            "rate": "1.0"
        },
        "country": "US",
        "theme": {
            "name": "Dawn",
            "id": 147441090860,
            "theme_store_id": 887,
            "role": "main",
            "handle": "null",
            "style": {
                "id": null,
                "handle": null
            }
        },
        "cdnHost": "americanpetfood.com/cdn",
        "routes": {
            "root": "/"
        },
        "loadFeatures": [],
        "autoloadFeatures": [],
        "featureAssets": {
            "shop-js": {
                "pay-button": [
                    "modules/client.pay-button_e62a1f0b.en.esm.js",
                    "modules/chunk.common_e44a5b52.esm.js"
                ],
                "installments-prequal": [
                    "modules/client.installments-prequal_aadc4197.en.esm.js",
                    "modules/chunk.common_e44a5b52.esm.js"
                ],
                "init-abg-demo": [
                    "modules/client.init-abg-demo_1acc6354.en.esm.js",
                    "modules/chunk.common_e44a5b52.esm.js"
                ],
                "init-shop-email-lookup-coordinator": [
                    "modules/client.init-shop-email-lookup-coordinator_cd99c937.en.esm.js",
                    "modules/chunk.common_e44a5b52.esm.js"
                ],
                "init-customer-accounts-sign-up": [
                    "modules/client.init-customer-accounts-sign-up_1d7e4776.en.esm.js",
                    "modules/chunk.common_e44a5b52.esm.js"
                ],
                "init-customer-accounts": [
                    "modules/client.init-customer-accounts_491f00bd.en.esm.js",
                    "modules/chunk.common_e44a5b52.esm.js"
                ],
                "init-shop-for-new-customer-accounts": [
                    "modules/client.init-shop-for-new-customer-accounts_3bb20c38.en.esm.js",
                    "modules/chunk.common_e44a5b52.esm.js"
                ],
                "login-button": [
                    "modules/client.login-button_554f1232.en.esm.js",
                    "modules/chunk.common_e44a5b52.esm.js"
                ],
                "discount-app": [
                    "modules/client.discount-app_3e1a44f8.en.esm.js",
                    "modules/chunk.common_e44a5b52.esm.js"
                ],
                "payment-terms": [
                    "modules/client.payment-terms_820b1b0f.en.esm.js",
                    "modules/chunk.common_e44a5b52.esm.js"
                ]
            }
        },
        "analytics": {
            "replayQueue": [],
            "publish": [],
            "visitor": []
        },
        "evids": [],
        "bind": [],
        "setSelectorByValue": [],
        "addListener": [],
        "postLink": [],
        "CountryProvinceSelector": [],
        "modules": true,
        "PaymentButton": {
            "init": []
        },
        "recaptchaV3": {
            "siteKey": "6LcCR2cUAAAAANS1Gpq_mDIJ2pQuJphsSQaUEuc9"
        }
    }
}

@rviscomi rviscomi requested a review from tunetheweb September 26, 2023 19:48
Copy link
Member

@tunetheweb tunetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There’s a recaptcha site key in the results. Do we wanna strip that out before storing?

dist/ecommerce.js Outdated Show resolved Hide resolved
Co-authored-by: Barry Pollard <[email protected]>
@rviscomi
Copy link
Member Author

Chatted offline, the ReCAPTCHA siteKey field seems to be relatively innocuous according to https://developers.google.com/recaptcha/intro.

@rviscomi rviscomi merged commit b3f119e into main Sep 26, 2023
@rviscomi rviscomi deleted the rviscomi-patch-1 branch September 26, 2023 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants