-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR body parsing improvement for test websites #98
Conversation
@tunetheweb seems like workflows in many cases run from base branch, skipping the changes from the head branch. Again I expected to test the new parsing right here, but had to use a separate repo. |
Don't understand what this means? I thought that's what the checkout of the head branch gets around: custom-metrics/.github/workflows/wpt-test.yml Lines 15 to 19 in f776b30
|
The workflow file is fetched even before we do checkout. Oh, ok. So we should be able to test it running with |
Custom metrics for https://almanac.httparchive.org/en/2022/WPT test run results: http://webpagetest.httparchive.org/results.php?test=231024_DM_9 Custom metrics for https://www.example.com/#dfsdf=sdWPT test run results: http://webpagetest.httparchive.org/results.php?test=231024_40_B {} Custom metrics for https://weston.ruter.net/WPT test run results: http://webpagetest.httparchive.org/results.php?test=231024_ZW_D {} Custom metrics for https://weston.ruter.net/about/WPT test run results: http://webpagetest.httparchive.org/results.php?test=231024_NK_F {} Custom metrics for https://weston.ruter.net/category/wordpress/WPT test run results: http://webpagetest.httparchive.org/results.php?test=231024_HH_H {} Custom metrics for https://weston.ruter.net/2023/07/01/running-the-wordpress-plugin-directory-slurper/WPT test run results: http://webpagetest.httparchive.org/results.php?test=231024_36_J {} |
Test description:In WordPress specific HTTP Archive research, we've so far typically relied on only home pages of each origin. However, home pages tend to have different layout than many other pages have, and our assumptions on e.g. performance are not segmented in any way regarding content type. It would be helpful to e.g. differentiate between specific performance patterns commonly applied on home pages vs on singular posts. Therefore this PR introduces a WordPress specific content type detection, based on the body classes that the CMS outputs by default. The PR adds 3 fields with information:
Some WebPageTest tests with this logic (using @westonruter's site as test candidate):
Test websites: |
@@ -1,7 +1,7 @@ | |||
name: Tests | |||
|
|||
on: | |||
pull_request_target: | |||
pull_request: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, so that's how we test it.
Just revert event name and ready to merge.
pull_request: | |
pull_request_target: |
P.S. had to remove test description so that we don't have a failing check.
Fixed issues with escaping markup code.
Related to workflow run issues in #96.