-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linter #21
Linter #21
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Is it worth adding npm run lint
commands to allow this to be run offline? At least for the common ones like eslint
, markdownlint
...etc? Would save you having to wait for a github action to complete just to realise you've missed one small thing.
|
IIRC standard is very opinionated and deliberately doesn’t allow config (which might be why it didn’t play well with prettier?) Whereas eslint is more configurable. But maybe for this simple use case it doesn’t matter? So happy to merge this and can improve if future if we wanna. |
Agree, it was just the fastest setup to get all checks green. I'm not familiar with how well P.S. My issue with prettier - it created 3 space indents in markdown sublists. |
I went with default superlinter setup.
Had to switch off two tasks:
because of the conflicts: