Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reviewing CWV report V2 #38

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Reviewing CWV report V2 #38

wants to merge 6 commits into from

Conversation

max-ostapenko
Copy link
Contributor

@max-ostapenko max-ostapenko commented Dec 20, 2024

  • Handling null adoption ⇒ 0
Screenshot 2024-12-20 at 17 01 49
  • Calculating technology origins and adoption metric based on the crawl data (category origins was already like this)
    Important: in core_web_vitals.technologies origins are lower due to CrUX join, but there all the metrics are relative to CrUX.

  • using a new wappalyzer.technologies table following Category descriptions wappalyzer#89

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • definitions/output/reports/cwv_tech_categories.js: Evaluated as low risk
Comments suppressed due to low confidence (1)

definitions/output/reports/cwv_tech_technologies.js:13

  • Inconsistent naming of 'technology'. It should be consistently referred to as either 'tech.technology' or 'technology' throughout the file.
tech.technology
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant