[Fix] Correct scale factor in rotation propagation (use scalar_type(0.5)) #28
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In the predict step of the filter, the rotation propagation is computed by applying an exponential map via MTK::exp. Previously, scalar_type(1/2) was used as the scale factor, but because of integer division, this evaluated to 0 instead of the intended 0.5. This resulted in an incorrect (negative or NaN) input being passed to MTK::cos_sinc_sqrt, causing an assertion failure.
Changes
Testing
Notes
This fix addresses the propagation of the rotation state (in the predict step), ensuring numerical correctness by using the proper scale factor.