forked from vllm-project/vllm
-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SW-201504] Trigger Internal Tests #538
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
RonBenMosheHabana
requested review from
kzawora-intel,
madamczykhabana,
michalkuligowski and
mgawarkiewicz
as code owners
December 18, 2024 15:01
RonBenMosheHabana
force-pushed
the
SW-201504_1
branch
from
December 18, 2024 15:03
044acd2
to
889806c
Compare
RonBenMosheHabana
changed the title
[SW-201504] Trigger Internal Tests - DO NOT MERGE
[SW-201504] Trigger Internal Tests
Dec 18, 2024
kzawora-intel
approved these changes
Jan 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, please make sure actionlint passes and we can merge this
rsshaik1
pushed a commit
that referenced
this pull request
Jan 13, 2025
- Added actionlint.yaml to allow usage of self-hosted runners (without it actionlint will throw error) - I also tried to disable some of shellcheck warnings/errors but couldn't do that so probably this PR should be merged even though actionlint is failing - Update Trigger Jenkins workflow - now it will contain 4 jobs: 1. Dependency Scan - will fail the job if a dependency with high severity vulnerability will be part of the PR 2. CodeQL Scan - scan the python code itself 3. Calculate Tests To Trigger - will read the .jenkins/test_config.yaml file and based on it trigger all the tests configured on it 4. Tests - The tests running on Gaudi resources
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it seems that there is an issue with Gaudi infrastructure so tests will probably failed because they cannot be triggered , but the infrastructure for triggering the tests is ready
@kzawora-intel @mgawarkiewicz @michalkuligowski @madamczykhabana - please review and leave comments if you have some