Update requirements-hpu.txt for open telemetry tracing support #857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louie-tsai
requested review from
kzawora-intel,
madamczykhabana,
michalkuligowski,
mgawarkiewicz,
vivekgoe and
afierka-intel
as code owners
louie-tsai
force-pushed
the
open_telemetry_support
branch
from
44a0d2e to
df648ad
Compare
michalkuligowski
requested changes
Feb 27, 2025
| @@ -9,3 +9,5 @@ tabulate | |||
| setuptools>=61 | |||
| setuptools-scm>=8 | |||
| vllm-hpu-extension @ git+https://github.com/HabanaAI/vllm-hpu-extension.git@8087a98 | |||
| opentelemetry-api | |||
There was a problem hiding this comment.
I am not sure if we want to add it here, those packages are not needed for other workloads. Also as I look into vllm project repo, they dont add it either to requirements file and leave it to user, also please see:
@kzawora-intel can you comment?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OPEA Project starts having OpenTelemetry tracing feature as below PR.
opea-project/GenAIExamples#1488
We have TGI/TEI enabled for the Open Telemetry tracing, and would like to also enable for vllm.
Current runtime issue is missing opentelemetry-api package, so have the PR to fix it.