-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove grunt #6112
Remove grunt #6112
Conversation
- Move browserify task from Grunt to Gulp Note: Do not use gulp-browserify
let minifyCss = require('gulp-minify-css'); | ||
let stylus = require('gulp-stylus'); | ||
let nib = require('nib'); | ||
|
||
require('gulp-grunt')(gulp); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this needed?
let rimraf = require('rimraf'); | ||
|
||
gulp.task('clean', (cb) => { | ||
rimraf('website/build', cb); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Our style is two spaces, not 4.
This is looking pretty good, just got some style notes for you. Is there a reason you haven't deleted the other unused tasks for the gruntfile? |
Sorry I forgot to clean up, I'll do it and push. |
What's the status on this? |
It's going to be pushed soon |
The build is failed because
on module |
No. Will look at it this weekend. |
@@ -0,0 +1,7 @@ | |||
import gulp from 'gulp'; | |||
|
|||
let rimraf = require('rimraf'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be import rimraf from 'rimraf';
Related issue with Travis Failed on CoffeeScript hubotio/generator-hubot#6 |
@@ -20,3 +54,5 @@ gulp.task('build:dev:watch', ['build:dev'], () => { | |||
gulp.task('build:prod', ['babel:common', 'prepare:staticNewStuff'], (done) => { | |||
gulp.start('grunt-build:prod', done); | |||
}); | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These two extra new lines are not necessary.
This reverts commit 85e3913.
@crookedneighbor apologies I'm pretty new at this project. I'm not sure what's causing the wrong css. Can you help checking? I might be that I might have missed something. |
After I compare the new css, the positions for sprites are off |
This reverts commit 1668f22.
… to make them async or sync
@noppanit, @crookedneighbor I am not too familiar with the codebase but I am with all the technologies and the stack involved. Tell me if you need help with this. |
There needs to be a lot of cleanup with all the npm modules we use. Node is up to v5.0 and many of the modules we use requires Once this PR is merged, I will file a new issue and a matching PR to clean up our dependencies and do a full check to make sure our code is properly linted and follows best practices |
@gauthamchandra thanks for help! A few things to keep in mind, though:
Let me know if you have any question |
@gauthamchandra I'm going to merge the conflict so please feel free to jump in this PR. I have two problems
Thanks for your help |
@paglias wow that is a massive set of changes in the new PR. I will forgo the changes and look into that PR instead. 👍 |
@gauthamchandra Sorry I was on the road so didn't have a chance to catch up. Were you able to take a look at the PR? |
@noppanit I got too busy over the weekend and wasn't able to look at it. I will try looking over it in the next 1-2 days. |
@crookedneighbor I think this PR is not going to work anymore as it's far behind the master. Is it ok if I create a new PR? |
Let's do smaller PRs extracting one grunt task at a time. |
Will do that. |
As we don't need Grunt and Gulp, this PR attempts to replace Grunt with Gulp.
Related: #5829