Remove grunt #6112

noppanit · 2015-10-26T21:55:54Z

As we don't need Grunt and Gulp, this PR attempts to replace Grunt with Gulp.

Related: #5829

- Move browserify task from Grunt to Gulp Note: Do not use gulp-browserify

crookedneighbor · 2015-10-26T22:01:57Z

tasks/gulp-build.js

+let minifyCss = require('gulp-minify-css');
+let stylus = require('gulp-stylus');
+let nib = require('nib');
+
 require('gulp-grunt')(gulp);


Is this needed?

crookedneighbor · 2015-10-26T22:43:40Z

tasks/gulp-clean.js

+let rimraf = require('rimraf');
+
+gulp.task('clean', (cb) => {
+	rimraf('website/build', cb);


Our style is two spaces, not 4.

crookedneighbor · 2015-10-26T22:44:25Z

This is looking pretty good, just got some style notes for you.

Is there a reason you haven't deleted the other unused tasks for the gruntfile?

noppanit · 2015-10-27T00:18:48Z

Sorry I forgot to clean up, I'll do it and push.

crookedneighbor · 2015-10-28T12:44:17Z

What's the status on this?

noppanit · 2015-10-28T12:58:43Z

It's going to be pushed soon

…emove_grunt

noppanit · 2015-10-28T17:01:39Z

The build is failed because

Error: Cannot find module 'xtend'

on module through2 Have you seen this before?

crookedneighbor · 2015-10-28T17:22:15Z

No. Will look at it this weekend.

crookedneighbor · 2015-10-28T17:22:38Z

tasks/gulp-clean.js

@@ -0,0 +1,7 @@
+import gulp from 'gulp';
+
+let rimraf = require('rimraf');


This should be import rimraf from 'rimraf';

noppanit · 2015-10-28T17:24:32Z

Related issue with Travis Failed on CoffeeScript hubotio/generator-hubot#6

crookedneighbor · 2015-10-28T17:33:03Z

tasks/gulp-build.js

@@ -20,3 +54,5 @@ gulp.task('build:dev:watch', ['build:dev'], () => {
 gulp.task('build:prod', ['babel:common', 'prepare:staticNewStuff'], (done) => {
  gulp.start('grunt-build:prod', done);
 });
+


These two extra new lines are not necessary.

This reverts commit 85e3913.

noppanit · 2015-11-06T03:25:54Z

@crookedneighbor apologies I'm pretty new at this project. I'm not sure what's causing the wrong css. Can you help checking? I might be that I might have missed something.

noppanit · 2015-11-06T04:44:01Z

After I compare the new css, the positions for sprites are off

…emove_grunt

This reverts commit 1668f22.

… to make them async or sync

gauthamchandra · 2015-11-08T17:44:38Z

@noppanit, @crookedneighbor I am not too familiar with the codebase but I am with all the technologies and the stack involved. Tell me if you need help with this.

gauthamchandra · 2015-11-08T17:50:06Z

There needs to be a lot of cleanup with all the npm modules we use. Node is up to v5.0 and many of the modules we use requires v0.10.x and give a ton of deprecated warnings.

Once this PR is merged, I will file a new issue and a matching PR to clean up our dependencies and do a full check to make sure our code is properly linted and follows best practices

paglias · 2015-11-08T17:56:15Z

@gauthamchandra thanks for help!

A few things to keep in mind, though:

We're going to upgrade to Node v4.2, which is an LTS, not to Node 5. We might review it later but for the time being we'll switch to Node 4.2
We're in the process of upgrading most dependencies, switching to ES6 with ESLint for code style and re-writing the API completely in a separate PR API v3 [WIP] #6144
We'll be happy to accept any PR that upgrades dependencies to the newest version as long as it doesn't break compatibility with API v2 and hasn't already been addressed in API v3 [WIP] #6144

Let me know if you have any question

noppanit · 2015-11-08T18:08:19Z

@gauthamchandra I'm going to merge the conflict so please feel free to jump in this PR. I have two problems

https://github.com/HabitRPG/habitrpg/pull/6112/files#diff-565c7aaf8560ac8a12c341fa07bed43aR60 I can't seem to use

gulp.task('test:prepare:build', ['test:prepare:translations', 'build:dev']); in Travis. The process wouldn't exit I suspect it's because some of the tasks hanging and wouldn't exit and Travis killed the build.

I can't seem to figure out the discrepancy of the cssmin between gulp and grunt. The generated css seems to be broken in gulp

Thanks for your help

gauthamchandra · 2015-11-08T20:39:09Z

@paglias wow that is a massive set of changes in the new PR. I will forgo the changes and look into that PR instead. 👍

noppanit · 2015-11-23T06:55:27Z

@gauthamchandra Sorry I was on the road so didn't have a chance to catch up. Were you able to take a look at the PR?

gauthamchandra · 2015-11-24T20:22:04Z

@noppanit I got too busy over the weekend and wasn't able to look at it. I will try looking over it in the next 1-2 days.

noppanit · 2015-12-31T00:05:51Z

@crookedneighbor I think this PR is not going to work anymore as it's far behind the master. Is it ok if I create a new PR?

crookedneighbor · 2015-12-31T00:38:10Z

Let's do smaller PRs extracting one grunt task at a time.

noppanit · 2015-12-31T00:59:50Z

Will do that.

noppanit added 5 commits October 24, 2015 00:56

Deleted clean task from Gruntfile and add gulp clean to gulp

eb7ee47

- Upgraded browserify to latest version

d35b856

- Move browserify task from Grunt to Gulp Note: Do not use gulp-browserify

Add gulp-minify-css

8cc16c7

Add gulp-stylus

a3def0e

Add gulp copy task

2d34e6d

crookedneighbor reviewed Oct 26, 2015
View reviewed changes

Merged with upstream develop

b891288

crookedneighbor reviewed Oct 26, 2015
View reviewed changes

noppanit added 8 commits October 28, 2015 11:18

Clean up old code and change the tab to be 2 spaces

4eab9f6

Merge branch 'develop' of https://github.com/HabitRPG/habitrpg into r…

2f61f7b

…emove_grunt

Convert tab to 2 spaces

5ee6901

Convert tab to spaces again with search and replace

7e6962c

Convert tab to spaces again with search and replace

87a6058

Convert tab to spaces again with search and replace

eb524f5

Add gulp-rename npm to package.json

e10422f

Mistyped character in gulp build

d78f0f0

crookedneighbor reviewed Oct 28, 2015
View reviewed changes

Use ES6 style to import rimraf

2aebfa1

crookedneighbor reviewed Oct 28, 2015
View reviewed changes

noppanit added 2 commits October 28, 2015 15:32

Finish loadManifestFiles task. It's been migrated to Gulp

f9fbc3c

Add task hashres

1388e67

noppanit added 9 commits November 5, 2015 17:11

Typo for lodash

70c6a4a

Typo for merge-stream

8ea5793

fixed the path of i18n.js file

69a1211

Revert to call the callback

0fb341a

Trigger

ea1d3f5

Build with exec testBin

85e3913

Revert "Build with exec testBin"

6cda804

This reverts commit 85e3913.

Call callback to finish the task

af7b660

Try without callback

1668f22

noppanit added 3 commits November 6, 2015 15:36

Merge branch 'develop' of https://github.com/HabitRPG/habitrpg into r…

e9a7df8

…emove_grunt

Revert "Try without callback"

f771fcb

This reverts commit 1668f22.

Run task with exec instead. It seems gulp tasks have to be rearranged…

bb5df68

… to make them async or sync

Merged with upstream

d5c09bd

Merged with master

e010c68

SabreCat added the status: pr: with author: needs work label Nov 24, 2015

crookedneighbor closed this Jan 1, 2016

Alys mentioned this pull request Sep 8, 2016

Migrate existing Grunt tasks to Gulp #5829

Closed

SabreCat removed the status: pr: with author: needs work label Jul 20, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove grunt #6112

Remove grunt #6112

noppanit commented Oct 26, 2015

crookedneighbor Oct 26, 2015

crookedneighbor Oct 26, 2015

crookedneighbor commented Oct 26, 2015

noppanit commented Oct 27, 2015

crookedneighbor commented Oct 28, 2015

noppanit commented Oct 28, 2015

noppanit commented Oct 28, 2015

crookedneighbor commented Oct 28, 2015

crookedneighbor Oct 28, 2015

noppanit commented Oct 28, 2015

crookedneighbor Oct 28, 2015

noppanit commented Nov 6, 2015

noppanit commented Nov 6, 2015

gauthamchandra commented Nov 8, 2015

gauthamchandra commented Nov 8, 2015

paglias commented Nov 8, 2015

noppanit commented Nov 8, 2015

gauthamchandra commented Nov 8, 2015

noppanit commented Nov 23, 2015

gauthamchandra commented Nov 24, 2015

noppanit commented Dec 31, 2015

crookedneighbor commented Dec 31, 2015

noppanit commented Dec 31, 2015

		@@ -0,0 +1,7 @@
		import gulp from 'gulp';

		let rimraf = require('rimraf');

Remove grunt #6112

Remove grunt #6112

Conversation

noppanit commented Oct 26, 2015

crookedneighbor Oct 26, 2015

Choose a reason for hiding this comment

crookedneighbor Oct 26, 2015

Choose a reason for hiding this comment

crookedneighbor commented Oct 26, 2015

noppanit commented Oct 27, 2015

crookedneighbor commented Oct 28, 2015

noppanit commented Oct 28, 2015

noppanit commented Oct 28, 2015

crookedneighbor commented Oct 28, 2015

crookedneighbor Oct 28, 2015

Choose a reason for hiding this comment

noppanit commented Oct 28, 2015

crookedneighbor Oct 28, 2015

Choose a reason for hiding this comment

noppanit commented Nov 6, 2015

noppanit commented Nov 6, 2015

gauthamchandra commented Nov 8, 2015

gauthamchandra commented Nov 8, 2015

paglias commented Nov 8, 2015

noppanit commented Nov 8, 2015

gauthamchandra commented Nov 8, 2015

noppanit commented Nov 23, 2015

gauthamchandra commented Nov 24, 2015

noppanit commented Dec 31, 2015

crookedneighbor commented Dec 31, 2015

noppanit commented Dec 31, 2015