Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployment: Compare and merging develop branch to main branch #307

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

simonreddy2001
Copy link
Collaborator

Description

To deploy the main branch on heroku where develop branch has to merge to main(production) up to date.
Please provide a short summary explaining what this PR is about.

Fixes # 134

How to test?

npm run dev and deploy on heroku (production)
Please provide a short summary how your changes can be tested?

Checklist

  • I have performed a self-review of my own code
  • I have followed the name conventions for CSS Classnames and filenames, Components names and filenames, Style filenames, if you are in doubt check the the project README.MD and here https://github.com/HackYourFuture-CPH/curriculum/blob/master/review/review-checklist.md
  • I have commented my code, particularly in hard-to-understand areas, if you code was simple enough mark the box anyway
  • I have made corresponding changes to the documentation, if you code was simple enough mark the box anyway
  • This PR is ready to be merged and not breaking any other functionality

simonreddy2001 and others added 3 commits December 15, 2021 16:18
Deployment: Compare and merging develop branch to master branch
Bug/FrontEnd: Fix scroll to top instead of staying where you stopped on previous page
@simonreddy2001 simonreddy2001 requested a review from a team as a code owner December 30, 2021 08:28
@chklueter chklueter temporarily deployed to webshop-clas-develop-l6ab2juq8 December 30, 2021 08:28 Inactive
@netlify
Copy link

netlify bot commented Jan 25, 2022

❌ Deploy Preview for class18-fp-storybook failed.

🔨 Explore the source changes: 63aeb05

🔍 Inspect the deploy log: https://app.netlify.com/sites/class18-fp-storybook/deploys/61f018d68d2f8f00074a8bb4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants