Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

database week1 #21

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jeli1991
Copy link

No description provided.

Copy link

@Elia-Git Elia-Git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job in general and would just want you to remember always use the same format. A table or column naming should always be in the same format(where you use lower case, & upper case like task, and STATUS but will expect the table names to be made as task, status, etc) for good practice & minimize errors.
This might only not be a doubt when it comes to OS.
In MySQL, the default behavior regarding case-sensitivity depends on the underlying operating system. On Windows, table and column names are not case-sensitive by default, while on Unix/Linux platforms, they are case-sensitive.

You can merge it & pay extra attention in the issues mentioned above.

Comment on lines +8 to +22
SELECT *
FROM task
WHERE status_id = (
SELECT id
FROM STATUS
WHERE NAME = 'done'
);

SELECT *
FROM task
WHERE status_id != (
SELECT id
FROM STATUS
WHERE NAME = 'done'
);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here I can't see in which status a task is as I (any external viewer) will not understand (not easily if at least) what status_id=3 meant. We don't even have a status name in the table task. So we need to get some information from other related tables (by joining).
Check this if it can help---

SELECT task.id,title,due_date, status.name
FROM task
JOIN status ON task.status_id=status.id
WHERE status.name="Done";

-- Find all the tasks that are not marked as not done

SELECT task.id,title,due_date, status.name
FROM task
JOIN status ON task.status_id=status.id
WHERE status.name!="Done";

Comment on lines +38 to +44
SELECT title
,(
SELECT NAME
FROM STATUS
WHERE id = task.status_id
) AS status_text
FROM task;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good here,thx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants