feat: expose outsideClickIgnoreClass #5645
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5645 +/- ##
==========================================
- Coverage 96.98% 96.96% -0.03%
==========================================
Files 30 30
Lines 3355 3365 +10
Branches 1416 1421 +5
==========================================
+ Hits 3254 3263 +9
- Misses 99 100 +1
Partials 2 2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
meriouma
force-pushed
the
dev/expose-outsideClickIgnoreClass
branch
from
bf631a0 to
8eee286
Compare
meriouma
force-pushed
the
dev/expose-outsideClickIgnoreClass
branch
from
8eee286 to
b1150b1
Compare
|
Can you check the code coverage and see if there's something you can add to get to our coverage levels? |
|
@claude review this code |
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
Adds test case to cover the scenario where outsideClickIgnoreClass is explicitly set to undefined, ensuring the fallback to default props is properly tested and improves test coverage for line 1327 in index.tsx. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
I tried, I think the issue is with codecov, as I believe the code should be covered with the tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem
We'd like to configure the name of the click outside ignore class.
Changes
Add clickOutsideIgnoreClass to the DatePicker component
To reviewers
Contribution checklist