Fixed bug in update_extensionNames which would break existing GPOs #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed bug where update_extensionNames would always fail over to just writing the new values instead of maintaining the existing values due to attempting to perform .split() on a list.
|
Hi, Would this fix any of the issues in the existing bug reports? Perhaps #5 ? Thanks! |
I don't think so - I haven't tried to debug that issue, but I suspect it's to do with the XML structure of ScheduledTasks becoming damaged. My fix for that would be to back the file up first if possible, and copy it back over if the issue happens. |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed bug where update_extensionNames would always fail over to just writing the new values instead of maintaining the existing values due to attempting to perform .split() on a list.