Now shows warning before closing unsaved note

[R4H33M]

Needed to refactor the quit logic of the app, but I think now the code is cleaner.
Fixes #13

[R4H33M]

I think I understood what you suggested, and I have changed my code to follow the coding guidelines.

[R4H33M]

Man these invisible trailing tabs get me everytime. Thanks for pointing them out.

[owenca]

A couple of issues:

• Label the Save button "Save", not "Save first", to be consistent with other applications.
• After Save, the program should quit. (See Pe and Koder, for example.)

[R4H33M]

I've changed it exactly how you said, Ready for review!

[R4H33M]

We good now, chief(s)? :))

[humdingerb]

I checked out the PR again and now, after clicking "Save" in the alert, the file dialog blinks into existence before the app cquits without saving...

[R4H33M]

That's really strange. It didn't do that before, and now I double checked it again on another machine and it works without any flaws. Did you test the latest version of the PR?
From the code, one would expected it to work as intended. I don't see any issues, do you?

---

(obligatory meme ;)))

[humdingerb]

I just removed the checked out branch and re-fetched it. Still seeing the same behaviour on gcc2. Using gcc8, it crashes with https://linx.li/takenotes-99812-debug-15-12-2019-19-23-02.report

[R4H33M]

Weird. I honestly have no clue why this would happen.

[owenca]

It crashes on x86 (gcc8) for me too. Also, on gcc2, if you open an existing note and then quit without editing it at all, you can't quit without seeing the dialog first. @R4H33M can you fix it?

[owenca]

It doesn't work when opening an existing note and then quit without changing the note.

[owenca]

One more bug: the dialog doesn't pop up if you change the note and then close the window. This is probably what @humdingerb was talking about.

[humdingerb]

How do we want to continue on here?
I played around a bit more and found that there's no crash when building with DEBUGGER=TRUE. Probably I had that on when I tested before...

The crash also disappears on gcc2 when built normally when changing the if (!fSaveMessage) in QuitRequested() to if (fSaveMessage == NULL). On gcc8 it still crashes though...

[owenca]

I think the two non-crash bugs should be fixed first and then the crash tracked down.

The crash also disappears on gcc2 when built normally when changing the if (!fSaveMessage) in QuitRequested() to if (fSaveMessage == NULL).

That's weird.

[R4H33M]

Oh hello. I was just working on fixing these issues, and through my testing I see very strange and unique behaviour - these bugs do not seem straightforward to fix.

They seem really hard, but I will continue attempting to fix this bug, and will update you as I go along. Any support would be greatly appreciated. Also, it might be a few days before we reach a potential solution.

[scottmc]

There's been a few other merged pull requests on TakeNotes since this pull request was first opened. Please check it with the latest upstream changes to see if it affects this code at all.

[scottmc]

So what's the status on this one? There's been a couple of other merged pull requests recently so I'm assuming it needs to at least be rebased?

[R4H33M]

Agreed.
I will still try to find a solution for these bugs, and it's quite an important addition so I don't think we should drop it quite yet.

[R4H33M]

I am closing this PR, as I will be starting over with fixing issue #13.
A new PR will be opened soon.