Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix : Display of save button and share on twitter function #9

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

c4coderandcreator
Copy link

This PR fixes :

  • save button visibility : save button is visible since the beginning while it is required to be visible after the result is generated.
  • added a feature : now users will be able to share the roast directly from the website .
github.roast.mp4

…e on twitter for Results to be shared as tweet
Copy link

vercel bot commented Jun 23, 2024

@c4coderandcreator is attempting to deploy a commit to the Haimantika's projects Team on Vercel.

A member of the Team first needs to authorize it.

@Haimantika
Copy link
Owner

Thanks @c4coderandcreator for the PR. I am adding a new OpenAI API key. That will fix the no roast available error. Maybe you can then do a second check and let me know?

@Haimantika
Copy link
Owner

Hi @c4coderandcreator please fix the conflicts and then send a similar video :)

@c4coderandcreator
Copy link
Author

Thanks @c4coderandcreator for the PR. I am adding a new OpenAI API key. That will fix the no roast available error. Maybe you can then do a second check and let me know?

no roast available is for me only ( as my api key is exceeding the limit ) but it will work with the project !! I have placed the code in such way that it will fit with yours

@c4coderandcreator
Copy link
Author

Hi @c4coderandcreator please fix the conflicts and then send a similar video :)

ok !!

@c4coderandcreator
Copy link
Author

c4coderandcreator commented Jun 23, 2024

Hi @c4coderandcreator please fix the conflicts and then send a similar video :)

solved the conflicts !! Please review it

@c4coderandcreator
Copy link
Author

@Haimantika please review and let me know if any modification is needed.
Thanks !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants