Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sangheili Secondary Armor Sprites #3537

Merged
merged 23 commits into from
Mar 2, 2024

Conversation

nameacow
Copy link

@nameacow nameacow commented Feb 9, 2024

Adding multiple new sprites so that every class of Sangheili is unique and not just a re-color. Potential plan to add a secondary armor system akin to ODST's four 'classes' (without the different tiny perks each has).

also first PR so i could be doing this completely wrong!! we will find out!!

  • Major Sprite
  • Spec-Ops Sprite
  • Ultra Sprite
  • Coding additions

🆑 nameacow01
rscadd: Multiple new secondary skins for Sangheili, all based off Reach armors. Ranger, Spec ops, Ultra.
/:cl: nameacow01

@nameacow
Copy link
Author

i should probably stop testing github functions on a pr, huh

@nameacow
Copy link
Author

All the coding additions and majority of sprites are complete. Hopefully I can get the Shipmaster sprite and some personal testing done by the end of the week.

@nameacow
Copy link
Author

nameacow commented Mar 2, 2024

Everythings done, Just a pit of personal testing then putting up for review and merge, yipee.

I legit don't need everything since it's a subtype, just need the sprite changes.

i passed the low iq test
@BDpuffy420
Copy link
Collaborator

Once your test are done I believe hitting ready for review will set it PR in motion!

WHY DIDNT I JUST MAKE IT A SUBTYPE WHAT WAS WRONG WITH MEEEEE
Fixes spec-ops gloves.
fixes spec ops gloves
@nameacow nameacow marked this pull request as ready for review March 2, 2024 07:20
@nameacow nameacow requested review from a team as code owners March 2, 2024 07:20
@BDpuffy420 BDpuffy420 added Ready Ready for admin review/merge and removed in-progress labels Mar 2, 2024
@BDpuffy420 BDpuffy420 merged commit 7a040d5 into HaloSpaceStation:alpha Mar 2, 2024
18 checks passed
hs-cicero added a commit that referenced this pull request Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement/QOL Ready Ready for admin review/merge spriting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants