Automated fix for refs/heads/cf-engine-dns #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
<!-- If you know who should review your pull request, please assign it to that person, otherwise the pull request would get assigned randomly. If your pull request is for a specific language, please add the appropriate lang label. -->
This adds a new channel argument `GRPC_ARG_DSCP` which allows users to create classified gRPC streams with a Differentiated Services Code Point (DSCP) marking on the IP frames. The channel argument is handled on both clients and servers, but currently only on posix based systems. Fixes grpc#17225 **Background**: In addition to what is already described is grpc#17225, when gRPC is used in telco systems there is often a need to classify streams of importance. There can be multiple hops between two endpoints (e.g. between 2 telecom operators) and some streams that are more important than others (e.g. emergency call related or similar). By marking the IP packets using DSCP the aware routers can make a sound decision of the prioritization. This PR propose to use DSCP as the configuration value since its common for both IPv4/IPv6, an alternative would be to use a config name that includes TOS and Traffic Class. There might be more needed regarding documentation and end2end testing, but there I need some advice. **References** https://datatracker.ietf.org/doc/html/rfc2474 https://www.iana.org/assignments/dscp-registry/dscp-registry.xhtml <!-- Your pull request will be routed to the following person by default for triaging. If you know who should review your pull request, please remove the mentioning below. --> @yashykt
…n ( grpc#33428)" (grpc#33512) (grpc#33586) Along with an experiment this time <!-- If you know who should review your pull request, please assign it to that person, otherwise the pull request would get assigned randomly. If your pull request is for a specific language, please add the appropriate lang label. -->
…pc#33587) Similar to grpc#33542. Note that there's a ticket to automatically use the one specified in the --server_image_canonical flag, but for now we just hardcode. ref b/261911148, b/282106799.
HannahShiSFB
force-pushed
the
cf-engine-dns
branch
9 times, most recently
from
efa3a56 to
73b303a
Compare
HannahShiSFB
force-pushed
the
cf-engine-dns
branch
2 times, most recently
from
3d1e99b to
dd93fb5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PanCakes to the rescue!
We noticed that our 'sanity' test was going to fail, but we think we can fix that automatically, so we put together this PR to do just that!
If you'd like to opt-out of these PR's, add yourself to NO_AUTOFIX_USERS in .github/workflows/pr-auto-fix.yaml