Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modifier tap hold in keyboard toml #222

Merged
merged 7 commits into from
Dec 29, 2024

Conversation

hariseldon78
Copy link
Contributor

This pull request closes issue #221.

I have been able to test the MTH(A,LShift) and it works correctly, but for some reason the TH(X,Y) is not working yet: has it been tested before? I see that Via does not have a binding for the TapHold.

I used all caps for MTH and TH for consistency with the other Layer actions, and i used the ordering , for consistency with WM and LM.

@hariseldon78
Copy link
Contributor Author

i also fixed Lgui and Rgui to LGui to RGui, let me know if that was a bad idea.

docs/src/keyboard_configuration.md Outdated Show resolved Hide resolved
rmk-macro/src/layout.rs Show resolved Hide resolved
@HaoboGu
Copy link
Owner

HaoboGu commented Dec 27, 2024

I see that Via does not have a binding for the TapHold.

Yes, via/vial supports only ModifierTapHold and LayerTapHold.

Only basic keycodes are supported in normal TapHold:

rmk/rmk/src/action.rs

Lines 46 to 49 in 7970200

/// General tap/hold action. Because current BaseAction actually uses at most 7 bits, so we borrow 1 bit as the identifier of general tap/hold action.
///
/// Serialized as 1|BasicAction(7bits)|BasicAction(8bits).
TapHold(Action, Action),

I have a plan to use 32-bit keycode, which would eliminate this limitation in the future.

Copy link
Owner

@HaoboGu HaoboGu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much!

@HaoboGu HaoboGu merged commit 449c70c into HaoboGu:main Dec 29, 2024
0 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants