-
-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modifier tap hold in keyboard toml #222
Modifier tap hold in keyboard toml #222
Conversation
i also fixed Lgui and Rgui to LGui to RGui, let me know if that was a bad idea. |
Yes, via/vial supports only ModifierTapHold and LayerTapHold. Only basic keycodes are supported in normal TapHold: Lines 46 to 49 in 7970200
I have a plan to use 32-bit keycode, which would eliminate this limitation in the future. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks very much!
This pull request closes issue #221.
I have been able to test the MTH(A,LShift) and it works correctly, but for some reason the TH(X,Y) is not working yet: has it been tested before? I see that Via does not have a binding for the TapHold.
I used all caps for MTH and TH for consistency with the other Layer actions, and i used the ordering , for consistency with WM and LM.