WIP: RP2040 PIO UART #248
Merged
WIP: RP2040 PIO UART #248
+5,772
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@grabpot I think full-duplex could probably be pushed out to a separate PR, if that would help. It would be nice to get this one merged. |
added 2 commits
January 30, 2025 18:30
* Added new_half_duplex() and new_full_duplex() methods, where the former accepts one pin/buffer and the latter two * In Half Duplex mode, write() disables RX SM, writes buffer to TX FIFO, waiting for TX_NFULL interrupt if necessary, then re-enables RX SM * In Full Duplex mode, write() adds buffer to internal ring buffer, enables TX_NFULL interrupt and returns. Interrupt is then responsible for pushing data into TX FIFO. * In both modes, TX SM is programmed to toggle pin direction, rather than pin level
|
My wired lily58 use pio and half duplex uart, looking forward a milestone for testing |
added 9 commits
February 1, 2025 19:21
HaoboGu
reviewed
Feb 17, 2025
|
@grabpot Thanks very much! Looks good to me. Can I get this PR merged now? |
|
Single wire half-duplex is tested and working, both rust and config examples. |
|
Seems no issue for this PR, I'm merging it. Thanks very much @grabpot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First draft of implementing a half-duplex, single wire UART serial driver,
BufferedHalfDuplexUart, using the RP2040 PIO subsystem. Requires PR #235. Not complete, and still to do, in no particular order:rp2040_piofeature and optional dependencieskeyboard.tomlconfiguration