This repository has been archived by the owner on Jun 1, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 346
[Feature Request 2985] Custom username editor #3309
Open
edonaHajredinaj
wants to merge
2
commits into
Haptic-Apps:master
Choose a base branch
from
edonaHajredinaj:custom-name-editor
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[Feature Request 2985] Custom username editor #3309
edonaHajredinaj
wants to merge
2
commits into
Haptic-Apps:master
from
edonaHajredinaj:custom-name-editor
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@edonaHajredinaj Just a few nitpicks I have: please make |
@edonaHajredinaj Any updates? |
Guess I'll do it myself then... |
This comment has been minimized.
This comment has been minimized.
@edonaHajredinaj No worries, I've already done it :) |
Alexendoo
suggested changes
Jan 10, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, just some R.string.*
changes needed (allows them to be translated into different languages)
I've updated the string resources, we should use the AlertDialogWrapper for better theming of this popup |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Feature Request 2985, Added a custom username editor so that users can hide their username if someone looks at their phone screen.