-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add refresh token functionality #24
base: master
Are you sure you want to change the base?
Add refresh token functionality #24
Conversation
arnorietdijk
commented
Nov 24, 2020
- Added jwt-refresh-token-bundle
- Updated readme with how to configure the refresh token
Production Changes | From | To | Compare |
---|---|---|---|
gesdinet/jwt-refresh-token-bundle | NEW | v0.9.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer to have this optional, ie. allow the user to choose to activate refresh tokens or not
They have to add it their self to the files named in the readme, so they have a choice whether they use it or not. Maybe it's better to point it out more that the refresh token is optional? |
And maybe add the dependency to suggest? |
Which dependency? |
|
So just to be clear, you want to be able to add the bundle/dependency yourself if you want to use it instead of having it already required in the bundle? |
Yes, composer has a suggests option |
First time I heard about it but I agree with this way of adding the functionality. |