Port "Advanced Resolution" editor window from Shipwright #595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copy files from Shipwright. Bare minimum UIWidgets fixes to successfully build. Add window and button. Update CVar names to match current project.
And some fixes.
Typo fixes. Mirror MSAA slider with other PR. Formatting.
TODOs squashed. Other TODOs added for the remaining region-based disable logic.
inspectredc
reviewed
Jun 7, 2024
Comment on lines
+365
to
+374
| if (CVarGetInteger(CVAR_PREFIX_ADVANCED_RESOLUTION ".IgnoreAspectCorrection", 0)) { | ||
| // This setting is intentionally not exposed on PC platforms, | ||
| // but may be accidentally activated for varying reasons. | ||
| // Having this button should hopefully prevent support headaches. | ||
| ImGui::TextColored(messageColor[MESSAGE_QUESTION], ICON_FA_QUESTION_CIRCLE | ||
| " If the image is stretched and you don't know why, click this."); | ||
| if (UIWidgets::Button("Click to reenable aspect correction.")) { | ||
| CVarSetInteger(CVAR_PREFIX_ADVANCED_RESOLUTION ".IgnoreAspectCorrection", 0); | ||
| CVarSave(); | ||
| } |
There was a problem hiding this comment.
can we just force set the variable rather that giving them the button?
mckinlee
pushed a commit
to mckinlee/2ship2harkinian
that referenced
this pull request
Sep 23, 2024
|
To give an update regarding this PR: outside of prepping this window for the new Modern Menu and tweaking some of the UI widgets, this PR will be blocked until a fix with LUS is made to improve framebuffer clear handling. Currently, the "black bars" regions will retain any previous frame buffer data in those areas, causing a strobing effect between the swap buffers. The LUS issue is not caused by this PR, just calling out that this PR will expose this bad behavior as it is currently. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an editor window for advanced resolution controls. Based on HarbourMasters/Shipwright#3130
I will need some assistance in making this match 2ship UI style.
Build Artifacts