[Enhancement] Allow equipping Great Fairy Sword to the B Button #760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this is in a good enough state to set as ready for review now. |
mckinlee
pushed a commit
to mckinlee/2ship2harkinian
that referenced
this pull request
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an enhancement that allows you to equip/unequip the Great Fairy Sword to "B". This is done by pressing "A" on the Great Fairy Sword in the pause menu. Wearing the Fierce Deity, Bremen, Kamaro, or Blast masks will unequip the Great Fairy Sword from B.
Adds new hook: OnItemStolen. This hook executes when the bird near Milk Road steals an item from you and passes the stolen item as an argument.
Leaving as a draft for now because I would like input on the following items:How should equipping GFS to a C button behave when the enhancement is on? Should the C button use GFS normally, toggle it's state on B, or should we prevent GFS from being set to C?Having the GFS on B currently overrides the special B button actions of the Bremen and Blast masks. Is this acceptable?Build Artifacts