Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various fixes for interpolation #880

Merged
merged 3 commits into from
Dec 1, 2024
Merged

Various fixes for interpolation #880

merged 3 commits into from
Dec 1, 2024

Conversation

Archez
Copy link
Contributor

@Archez Archez commented Nov 27, 2024 •
edited by github-actions bot
Loading

Various interpolation fixes and cleanup.

Includes:

  • Fix interpolation for Link's feet shadow flashing on quick turns
  • Fix interpolation for actor circle shadows flashing on quick turns (like when holding a pot over Link's head)
  • Fix sand dust effect jumping between each Twinmold boss
  • Fix Goron Race large boulder breaking effect not being interpolated
  • Fix interpolation on vacuum particles for charging spin attack
  • Fix interpolation of water effects in Gyorg fight sometimes jumping
  • Fix interpolation on Honey&Darling floating hearts
  • Fix interpolation on rolling boulders and rolling snowballs when they respawn
  • Fix interpolation on environment particles/effects (snow, underwater, giants cutscene bubbles, etc) when they are "updated" to a new location

Drops some use of epoch for alternate values and switches some pointers to use more stable/relevant values

Build Artifacts

@Archez Archez force-pushed the more-interpolation-fixes branch from a94aade to e7bd18a Compare November 28, 2024 17:40
@Archez Archez force-pushed the more-interpolation-fixes branch from 9d601c0 to 8fb1868 Compare November 29, 2024 19:34
@Archez Archez force-pushed the more-interpolation-fixes branch from 8fb1868 to 5defbcc Compare December 1, 2024 01:31
@Archez Archez merged commit 78a0a0c into HarbourMasters:develop-satoko Dec 1, 2024
5 checks passed
@Archez Archez deleted the more-interpolation-fixes branch December 1, 2024 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garrettjoecox garrettjoecox garrettjoecox approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Archez @garrettjoecox