Fix text Poeverflow on Poes hint #4598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Malkierian
approved these changes
Nov 30, 2024
inspectredc
reviewed
Dec 3, 2024
Comment on lines
+387
to
+397
| case '\x05'://COLOR | ||
| case '\x06'://SHIFT | ||
| case '\x07'://TEXTID | ||
| case '\x0C'://BOX_BREAK_DELAYED | ||
| case '\x0E'://FADE | ||
| case '\x11'://FADE2 | ||
| case '\x12'://SFX | ||
| case '\x13'://ITEM_ICON | ||
| case '\x14'://TEXT_SPEED | ||
| case '\x15'://BACKGROUND | ||
| case '\x1E'://POINTS/HIGH_SCORE |
There was a problem hiding this comment.
Could these use the macros from message_data_fmt?
There was a problem hiding this comment.
There are name overlaps between CustomMessageManager's helper functions and some of the defines in message_data_fmt, causing build errors if I include it. It could be fixed with better src and CustommessageManager intergration, but it would be beyond the scope of this bugfix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4589 . This implements checks for the various control characters with operands to Auto-format to not consider /x01's there newlines.
Build Artifacts