Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NPC souls #4949

Open
wants to merge 21 commits into
base: develop
Choose a base branch
from
Open

NPC souls #4949

wants to merge 21 commits into from

Conversation

serprex
Copy link
Contributor

@serprex serprex commented Jan 24, 2025 •
edited by github-actions bot
Loading

Build Artifacts

@serprex serprex force-pushed the npc-souls branch 4 times, most recently from a686d44 to 9d8bfaf Compare January 26, 2025 18:32
@serprex
Copy link
Contributor Author

serprex commented Jan 26, 2025 •
edited
Loading

Listing things I need to do in PR description, but one point I'm just not sure how to handle are NPC souls which logically block (Talon, King Zora, Mido, other Kokiri guard)

So far I've only implemented Talon, but wondering if they'll require some kind of ghost actor which can only be dispelled once their soul is acquired. But that seems like quite a bit of work, so for first iteration I'd just want using the absence of a soul to be going out of logic. In that iteration Mido's soul wouldn't be implemented (edit: Talon at least can despawn his milk crates at castle to prevent early Zelda)

Another issue is Letter from Zelda / Song from Impa. Right now I'm thinking let those checks be acquired without souls, other option is to require both souls before Zelda's Letter is given

@serprex serprex force-pushed the npc-souls branch 7 times, most recently from bccc7e7 to 8294bc5 Compare January 29, 2025 02:55
@serprex serprex marked this pull request as ready for review January 29, 2025 04:23
@TheLynk
Copy link

TheLynk commented Feb 7, 2025

crash randomize seed in last version :
Ship of Harkinian.log
image
image
image
image
image
image
No location excluded and no trick / logic : glitchless

@serprex
Copy link
Contributor Author

serprex commented Feb 10, 2025

Disable ice traps. I need to fill in some more item text for that to function

@serprex serprex force-pushed the npc-souls branch 9 times, most recently from 846f0b6 to 70ddf5c Compare February 16, 2025 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@serprex @TheLynk