-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Rando] Shuffle Crates #5017
Open
A-Green-Spoon
wants to merge
74
commits into
HarbourMasters:develop
Choose a base branch
from
A-Green-Spoon:feature/cratesanity
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[Rando] Shuffle Crates #5017
A-Green-Spoon
wants to merge
74
commits into
HarbourMasters:develop
from
A-Green-Spoon:feature/cratesanity
+3,690
−104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into feature/cratesanity
…into feature/cratesanity
…into feature/cratesanity
…into feature/cratesanity
…into feature/cratesanity
…into feature/cratesanity
…into feature/cratesanity
…into feature/cratesanity
…into feature/cratesanity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows along with most features and settings for pots and grass: overworld/dungeon/all, including MQ, a custom model set, courtesy of @DanaTheElf, for when a crate holds a randomized item (including CTMC), and logic support. One additional feature is a set of GV/GF crates that aren't accessible in glitchless logic (outside of ER), but are shuffled in No Logic settings.
Thanks also to @leggettc18 for splitting up the location list to make room for the additional locations!
Build Artifacts