Upgrades Custom Messages to Hooks and ShipInit #5101
Draft
+1,819
−1,892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only for the items, other things previously covered by CustomMessage_Retrieve if exists have not yet been covered as of this commit and will either load their vanilla text or crash.
Specifically Dampe, Greg, Warp Songs, Frogs, Loach, Fishing Pole, and Saria
This is the last of the static hints
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is my effort to convert our old Custom Message systems to use the OnTextLoad hook that I backported from 2Ship, and ShipInit to replace our previous methods for displaying Custom Messages. Some articles, colors, and icons got lost in translation that I know of, so it's not 100% done yet. However these are all visual, so playtesters are safe to go ahead and try this build out to see if they can find any bugs like text popping up in the wrong places or hooks not getting registered properly.
Build Artifacts