Skip to content

Mica support on Win32 platform #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Luminoso-256
Copy link

Adds support for a window to utilize darkmode and Windows 11-style taskbars by defining SA_Win11 before inclusion of Slimapp. Requires that the app links to dwmapi.lib

image

Note that the changes require Windows 11 Insider Preview 22523 or higher to work for Mica. Before 22523, the only easy way to set Mica was through an undocumented attribute.

Not entirely sure if this is in scope, but was fun to add and figured I might as well PR it in case. Cheers!

@HardCoreCodin
Copy link
Owner

Hey, thanks for the contribution :)
Generally, I would want to avoid any additional specific dependencies, or operating system version requirements, as the whole point of the 'Slim' in the name there is to minimize dependencies and setup effort.
Though, as long as it's all technically 'optional' and doesn't impose any additional requirement (code would still compile in much older version of Window), then I don't mind accepting it.

@Luminoso-256
Copy link
Author

The code should still compile in older windows versions just fine. Anything added in my PR is wrapped in an #ifdef SA_Win11 block, so without that definition it imposes no extra requirements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants